search

Shynixn / MCCoroutine

MCCoroutine is a library, which adds extensive support for Kotlin Coroutines for Minecraft Server environments.
Other
210 stars 19 forks source link

Support latest minestom #121

Closed mani1232 closed 3 months ago

mani1232 commented 3 months ago
  • What's dev.hollowcube:minestom-ce-extensions:1.2.0 ?
  • Do not use relase candidate versions (e.g. 2.0.10-RC)
  • Do only modify the minestom modules. The other modules have been modified (e.g. Folia changes are not correct)

I'll start reviewing the individual changes, once these have been resolved.

  1. Minestom remove extensions, https://github.com/Minestom/Minestom/commit/e1140b58563c841a970a59731b0f5d2f2e7da027

  2. 2.0.X contains fixes from 2.0.0 release, im can set it to 2.0.0 if you want (coroutines RC version related to wasm target and support kotlin 2.0)

  3. Changed only gradle scripts. What exactly is wrong with it?

mani1232 commented 3 months ago

Temp repo

maven {
    url = uri("https://repo.worldmandia.cc/releases")
}
implementation("com.github.shynixn.mccoroutine:mccoroutine-minestom-core:2.18.1")
Shynixn commented 3 months ago

I'll review and merge your PR once i have got time.

Shynixn commented 3 months ago

Thank you for your contribution. Looks (mostly) fine. 👍