search

Shyp / eslint-config-shyp

An eslint configuration for Shyp projects
MIT License
0 stars 2 forks source link

update eslint rules for react #11

Closed adittes closed 6 years ago

adittes commented 6 years ago

While reviewing https://github.com/Shyp/bridge/pull/412 I noticed that eslint didn't raise an error when this.state was modified directly. This adds in rules to fix this, and some other errors that seem useful.

react/no-direct-mutation-state, react/jsx-key and react/jsx-no-target-blank introduce new errors in a few places in bridge and shyp.com, but those represent lingering mistakes in the codebase that should be fixed anyway.

https://www.pivotaltracker.com/n/workspaces/676433

akoskm commented 6 years ago

LGTM ✨

adittes commented 6 years ago

Thanks guys! I'll have PRs to address the new failures that this introduces soon