Rule tweaks - Githubissues

Shyp / eslint-config-shyp

An eslint configuration for Shyp projects

MIT License

0 stars 2 forks source link

Closed dylanpyle closed 8 years ago

dylanpyle commented 8 years ago

Require parentheses around arrow function arguments. We've mostly standardized on this for web code - it's more readable, and harder to confuse with other behaviors.
Move all warnings to errors. We never fix warnings, they just serve to make the local make lint output less readable, and they don't fail builds in CI. If there are cases we need console.log and friends, we can add one-off exceptions using inline comments.

dylanpyle commented 8 years ago

cc @Shyp/web and @Shyp/platform (y'all are using this repo now too, right?)

smmullen90 commented 8 years ago

👍

dgb commented 8 years ago

Interesting. I don't have strong feelings about these changes, but I'll let you know if I encounter anything in bumping.