search

SiEPIC / SiEPIC-Tools

Package for KLayout to add integrated optics / silicon photonics functionality (waveguides, netlist extraction, circuit simulations, etc)
Other
181 stars 90 forks source link

spice_netlist_export: Check pins to see if explicitly ordered numerically #115

Closed StefanPreble closed 4 years ago

StefanPreble commented 4 years ago

Summary: Checks pin names to see if explicitly ordered numerically. It requires first character in pin name to be a number and checks to make sure every pin is numbered.

This is required for general interoperability with foundry provided Design Kits in Lumerical INTERCONNECT.

If the pins aren't explicitly numbered the default ordering is used (electrical pins, optical IO then optical).

lukasc-ubc commented 4 years ago

Hi @StefanPreble,

What you propose makes sense.

In your code, I don't see a sorting function. Are the pins returned sorted already?

Also, could you please update the documentation on pins?

https://github.com/lukasc-ubc/SiEPIC-Tools/wiki/Component-and-PCell-Layout

and

https://github.com/lukasc-ubc/SiEPIC-Tools/wiki/Implementation-of-Netlist-extraction

Thanks!

StefanPreble commented 4 years ago

Thanks for the quick response. Yes, they are sorted already (alphabetically - so by adding the numbering to the beginning of the pin name, we leverage the existing sorting that already happens).

Yes - done. I've updated the documentation on my fork of the Wiki:

https://github.com/StefanPreble/SiEPIC-Tools/wiki/Component-and-PCell-Layout

https://github.com/StefanPreble/SiEPIC-Tools/wiki/Implementation-of-Netlist-extraction

Thank you!

lukasc-ubc commented 4 years ago

Thanks @StefanPreble. I couldn't find an easy way to push/pull your Wiki edits, but was able to copy your text over. Thanks!

StefanPreble commented 4 years ago

Thank you! For future reference, you can clone the two Wikis locally (i.e. https://github.com/lukasc-ubc/SiEPIC-Tools.wiki.git) and merge on your own machine, then push back to your master.

lukasc-ubc commented 4 years ago

I was able to clone them both, but unable to push my changes back to my own. On GitHub desktop, both yours and mine showed up under the “Other” category (read only).

On Apr 29, 2020, at 7:36 PM, StefanPreble notifications@github.com wrote:

Thank you! For future reference, you can clone the two Wikis locally (i.e. https://github.com/lukasc-ubc/SiEPIC-Tools.wiki.git https://github.com/lukasc-ubc/SiEPIC-Tools.wiki.git) and merge on your own machine, then push back to your master.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lukasc-ubc/SiEPIC-Tools/pull/115#issuecomment-621577819, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY37AFMZSV3G67OKCD2H6TRPDP37ANCNFSM4MT6AQ3Q.