search

SiEPIC / SiEPIC-Tools

Package for KLayout to add integrated optics / silicon photonics functionality (waveguides, netlist extraction, circuit simulations, etc)
Other
181 stars 90 forks source link

Update for GC array orientation check #171

Closed jevillegasd closed 2 years ago

jevillegasd commented 2 years ago

Changes in SiEPIC.scripts.layout_check to include [gc-array-orientation] information when testing the configuration of the opt_in and GC configuration.

lukasc-ubc commented 2 years ago

Very nice, @jevillegasd, thank you!

lukasc-ubc commented 2 years ago

@jevillegasd @mustafacc

I had previously defined the gc-array-orientation as a direction along the array, i.e. in the attached it would be 180º. However, it probably would be easier to define the direction of where the fiber array is coming from i.e., 270º. This would make it consistent with EHVA's definition.

What do you think?

If so, we should change SiEPIC tools, and DFT files in the PDKs.

image

thanks

jevillegasd commented 2 years ago

Would this still work for your test setups? (in case they use info from the DFT definition)

I can make the changes in the tools and the DFT files for the PDKs I have access to. (Athabasca, EBeam and AMF)