Closed jevillegasd closed 2 years ago
Very nice, @jevillegasd, thank you!
@jevillegasd @mustafacc
I had previously defined the gc-array-orientation as a direction along the array, i.e. in the attached it would be 180º. However, it probably would be easier to define the direction of where the fiber array is coming from i.e., 270º. This would make it consistent with EHVA's definition.
What do you think?
If so, we should change SiEPIC tools, and DFT files in the PDKs.
thanks
Would this still work for your test setups? (in case they use info from the DFT definition)
I can make the changes in the tools and the DFT files for the PDKs I have access to. (Athabasca, EBeam and AMF)
Changes in SiEPIC.scripts.layout_check to include [gc-array-orientation] information when testing the configuration of the opt_in and GC configuration.