search

SiEPIC / SiEPIC_EBeam_PDK

SiEPIC EBeam PDK & Library, for SiEPIC-Tools and KLayout
http://www.siepic.ubc.ca
Other
205 stars 145 forks source link

Update ebeam rib phase shifter folded inside #214

Closed Guowu-Mcgill closed 4 years ago

Guowu-Mcgill commented 4 years ago

Hi Professor Lukas,

I update the phase shifter. You may check from your side. I just copy and paste from local .py file. But it do not include symbols like "< >". I hope it will work.

lukasc-ubc commented 4 years ago

design by Guowu Zhang guowu.zhang@mail.mcgill.ca

there are tons of < >, unfortunately.

If you copy from the .py into the .lym file in KLayout, then save there, you won’t have that problem. If you are editing outside, would move the functions into a .py file and import them (for future work if need be).

I copied your file into KLayout and saved it again, and fixed it.

I notice you started with the old version of the PCell, which is missing the total_waveguide_length functionality (and perhaps other changes). Could you merge those in?

I have merged this into the main EBeam branch.

thanks!

Guowu-Mcgill commented 4 years ago

OK, i will merge those together!