Closed Hang-Bobby-Zou closed 1 month ago
Attention: Patch coverage is 87.68473%
with 25 lines
in your changes missing coverage. Please review.
Project coverage is 73.26%. Comparing base (
0db1171
) to head (8486160
).
Files | Patch % | Lines |
---|---|---|
...Beam/pymacros/pcells_SiN/EBeam_GC_SiN_1310_8deg.py | 87.68% | 25 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi Bobby,
1) numpy is now part of KLayout, so we should just use that. 2) we have a function make_pin, can you use that instead? 3) have you verified the cell using simulation and/or fabrication? 4) does this cell only work for 1.31 µm, or could it be used for other wavelengths, say 900, 1550, etc?
from SiEPIC.utils.layout import make_pin
def make_pin(cell, name, center, w, layer, direction, debug=False):
'''
Makes a pin that SiEPIC-Tools will recognize
cell: which cell to draw it in
name: text label for the pin
center: location, int [x,y]
w: pin width
layer: layout.layer() integer type, or string
direction =
0: right
90: up
180: left
270: down
Units: input can be float for microns, or int for database units (typ. nm)
'''
Added an adapted PCell for OBand GC