Create EBeam_GC_SiN_1310_8deg.py

Hang-Bobby-Zou commented 1 month ago

Added an adapted PCell for OBand GC

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.68473% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (0db1171) to head (8486160).

Files	Patch %	Lines
...Beam/pymacros/pcells_SiN/EBeam_GC_SiN_1310_8deg.py	87.68%	25 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #292 +/- ## ========================================== + Coverage 73.00% 73.26% +0.25% ========================================== Files 93 94 +1 Lines 11284 11487 +203 ========================================== + Hits 8238 8416 +178 - Misses 3046 3071 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lukasc-ubc commented 1 month ago

Hi Bobby,

1) numpy is now part of KLayout, so we should just use that. 2) we have a function make_pin, can you use that instead? 3) have you verified the cell using simulation and/or fabrication? 4) does this cell only work for 1.31 µm, or could it be used for other wavelengths, say 900, 1550, etc?

from SiEPIC.utils.layout import make_pin

def make_pin(cell, name, center, w, layer, direction, debug=False):
    '''
    Makes a pin that SiEPIC-Tools will recognize
    cell: which cell to draw it in
    name: text label for the pin
    center: location, int [x,y]
    w: pin width
    layer: layout.layer() integer type, or string
    direction = 
        0: right
        90: up
        180: left
        270: down

    Units: input can be float for microns, or int for database units (typ. nm)
    '''

SiEPIC / SiEPIC_EBeam_PDK

Create EBeam_GC_SiN_1310_8deg.py #292

Codecov Report