SiEPIC / SiEPIC_EBeam_PDK

SiEPIC EBeam PDK & Library, for SiEPIC-Tools and KLayout
http://www.siepic.ubc.ca
Other
201 stars 142 forks source link

pbs_e_skid component added to the library of beta components #294

Closed AndrazDebevc closed 1 month ago

AndrazDebevc commented 1 month ago

I added the polarization beam splitter component to the pdk. I included the link to the paper and I used the "Make SiEPIC Component from cell" tool to generate the ports and labels. Did I upload the gds file to the right directory?

Please let me know, if there is something I should modify/add.

Andraz

lukasc-ubc commented 1 month ago

Looks good! Request:

1) instead of the top cell being "TOP", replace with the file name. Remove the unused cells (waveguides).

image

2) file/cell name, suggestion: pbs_1550_eskid (we have eskid instead of e_skid in the Waveguides.XML configuration).

image

3) suggest adding another text which provides a brief description, e.g., Polarization Beam Splitter Input: TE & TM 1550 in opt3 (or is it opt2?) Output: TM in opt4, TE in opt1

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.35%. Comparing base (ada3345) to head (684f218).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #294 +/- ## ======================================= Coverage 73.35% 73.35% ======================================= Files 96 96 Lines 11706 11706 ======================================= Hits 8587 8587 Misses 3119 3119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.