Closed AndrazDebevc closed 1 month ago
Looks good! Request:
1) instead of the top cell being "TOP", replace with the file name. Remove the unused cells (waveguides).
2) file/cell name, suggestion: pbs_1550_eskid (we have eskid instead of e_skid in the Waveguides.XML configuration).
3) suggest adding another text which provides a brief description, e.g., Polarization Beam Splitter Input: TE & TM 1550 in opt3 (or is it opt2?) Output: TM in opt4, TE in opt1
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.35%. Comparing base (
ada3345
) to head (684f218
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I added the polarization beam splitter component to the pdk. I included the link to the paper and I used the "Make SiEPIC Component from cell" tool to generate the ports and labels. Did I upload the gds file to the right directory?
Please let me know, if there is something I should modify/add.
Andraz