search

SiEPIC / openEBL-2024-07-Si-Heaters

Submission for fabrication of silicon photonics for a SiEPIC openEBL run
https://siepic.ca/openebl/
MIT License
1 stars 34 forks source link

Issues with electro-optical example submissions #15

Open PetervandenDoel opened 5 months ago

PetervandenDoel commented 5 months ago

This issue was brought to our attention by @boy4429856821

This issue is the same between the example submissions EBeam_heaters_BraggGratingwithHeater.gds EBeam_heaters_BraggGratingwithHeater.oas, EBeam_heaters_BraggGratingwithHeater.yaml and in test.gds and test.yaml.

The optical coordinates do not seem to get populated properly in the Yaml file when using these examples and the included yaml files cause testcreator to throw an error in vscode or crash when run in the command line. Picture1

Looking at the example it seems that the optical coordinates are there, but the electrical coordinates are not populated and multiple electrical test sequences are defined . Picture4

Both the gds and oas files have an electrical pad that is named like this Picture2

One is able to use the software to create a yaml file, but it will not contain the coordinates of the electrical pad despite defining an electrical test sequence. Test creator displays two error messages when importing the .txt file from a GDS containing an _G in the electrical pad name. The first error has to do with the naming of the electrical pad label and the other error has to do with the last line in the .txt file which has something to do with photonic wire bonding locations; this error doesn't seem to have a bearing on how the Yaml files are generated thankfully. Interestingly enough, I can open a yaml that I generate even when it doesn't contain electrical coordinates without causing test creator to crash, but the default yaml example does cause it to crash. It could be that the particular sequences that were defined create an error condition or it could be that the example yaml was generated using an older version of the software. Picture3

The test creator readme says that electrical pads need to be labeled simply with the name of the device without _G at the end

Picture5 One of the images in the testcreator readme shows an electrical pad named with a completely different name from the optical coupler so this may also be a documentation error Picture6

When I remove the _G from the electrical pad name I am able to generate a yaml file that contains the electrical coordinates in this format [G, xcoord, ycoord]. It still continues to generate an error message about the wire bonding line in the text file, but that doesn't seem to effect the yaml itself. Picture7

Side-by-side comparison of the default Yaml example and the Yaml that I generated after removing the _G. As one can see, the electrical coordinates are properly populated in the yaml that I generated but not the one that is given in the default example. Picture8

lukasc-ubc commented 4 months ago

@JymBone5 @PetervandenDoel could you please take a look at this?

thank you

JymBone5 commented 4 months ago

looks like the original issue was due to the change in naming convention between routine and sequences, that has been fixed it looks like, the last error message is due to a new section someone has added to the automated layout extraction, isn't causing any issues but I will make sure that next section is taken into account and not included, issue should be resolved now