search

SiGMobileUIUC / car_pool_app

1 stars 0 forks source link

Use Listview.Builder with ListTiles instead of HardCoding in Account.Dart #5

Closed adrian-szwejk closed 12 months ago

adrian-szwejk commented 1 year ago

Hey, so for listTiles created within account page I noticed their hard coded in each of them even though they all have a very similar format and input. So, in order to help save space in this already really long file I recommend checking out Listview.builder and use the ListTiles as the children: https://www.geeksforgeeks.org/listview-builder-in-flutter/. image

ashah305 commented 1 year ago

Will take a look this week, thanks!

ashah305 commented 1 year ago

I completed this. Adrian just look it over when you get the chance, and if it is good then go ahead and close it. If not, lmk what to fix.

adrian-szwejk commented 1 year ago

Yeah, it looks like there was some sizing issue with using the listview.builder inside of a singleChildScrollView so I switched it over to a Sliver system with Sliver list and SliverToBoxAdapter for the pfp. There seems to still be some unnecessary code within the SliverList/Listview.builder now as you just moved the switch case inside of it rather than creating a list and using the index to grab information without cases.

adrian-szwejk commented 12 months ago

Finished sliverlist.builder and connection with parameterized function commit 8f97a20