search

SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

Add cross point switch HL for EOS and QMS card #190

Closed matthias-schuessler closed 1 year ago

matthias-schuessler commented 1 year ago

Adds a file XPT.py containing the HL for EOS and QMS card.

Also contains a change to Keithley2000 adding the option to set NPLC in DC voltage mode

codecov[bot] commented 1 year ago

Codecov Report

Base: 35.90% // Head: 34.44% // Decreases project coverage by -1.46% :warning:

Coverage data is based on head (fc6d226) compared to base (26fcc9f). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #190 +/- ## ========================================== - Coverage 35.90% 34.44% -1.47% ========================================== Files 79 80 +1 Lines 5284 5508 +224 ========================================== Hits 1897 1897 - Misses 3387 3611 +224 ``` | [Impacted Files](https://codecov.io/gh/SiLab-Bonn/basil/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn) | Coverage Δ | | |---|---|---| | [basil/HL/XPT.py](https://codecov.io/gh/SiLab-Bonn/basil/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn#diff-YmFzaWwvSEwvWFBULnB5) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

leloup314 commented 1 year ago

Thanks for the contribution, looks good! Would be nice if you could add an example to the examples folder. If you don't find any of the existing folders fitting (e.g. lab_devices, etc) you can also add a new folder (e.g. EOS or serial_powering, etc). The example should consist of a config-yaml as well as a Python script showcasing the usage and basic functionality of the contents of the XPT.py HL.

matthias-schuessler commented 1 year ago

I talked with Florian and Yannick about adding an example. We think that it doesn't make sense to add one, since our only application for the switches is the QMS-card, which needs bdaq to operate. Thus, an example wouldn't work in basil without adding the entire bdaq class.

leloup314 commented 1 year ago

Okay, then let me know once this is ready to be merged

matthias-schuessler commented 1 year ago

From my end, this is ready to merge.