search

SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

agilent_33250a.yaml addded missing commands #193

Closed dschuechter closed 1 year ago

dschuechter commented 1 year ago

Updated agilent_33250a.yaml to be able to toggle the output within basil

codecov[bot] commented 1 year ago

Codecov Report

Base: 35.90% // Head: 35.90% // No change to project coverage :thumbsup:

Coverage data is based on head (f3550e9) compared to base (1e4fc9b). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #193 +/- ## ======================================= Coverage 35.90% 35.90% ======================================= Files 79 79 Lines 5283 5283 ======================================= Hits 1897 1897 Misses 3386 3386 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

leloup314 commented 1 year ago

Cool, thanks! If I remember correctly, there was also an issue using the example description yaml for the oszilloscope, right? Could you maybe also adapt this within this PR?

dschuechter commented 1 year ago

I can briefly create an example for examples/lab_devices. I had to create a new tektronix_tds3034b.py in basil/HL/ since the older oscilloscope returns values differently.

So in total there would be the following new files: examples/lab_devices/tektronix_tds3034B.yaml examples/lab_devices/tektronix_oscilloscope_tds3034b.py basil/HL/tektronix_tds3034B.yaml

I have not tested all commands. Some functions of the newer oscilloscopes might not work. DAQ and controlling standard settings like Scale, Pos, CH, Trigger,... work.

I thought that this should be a new PR

leloup314 commented 1 year ago

In that case you are right, it should be a different PR! Thanks!