SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

PRJ: Added support for Tektronix TDS3034B #194

Closed dschuechter closed 1 year ago

dschuechter commented 1 year ago

Added support for the Tektronix TDS3034B oscilloscope incl. an example.

It shares the same device .yaml file as the newer Tektronix oscilloscopes. For that reason, some commands that work on newer devices might not be compatible with the old TDS3034B. Standard tasks like DAQ, configuration of the oscilloscope and so on are working.

codecov[bot] commented 1 year ago

Codecov Report

Base: 35.90% // Head: 35.21% // Decreases project coverage by -0.70% :warning:

Coverage data is based on head (b5da2b6) compared to base (1e4fc9b). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #194 +/- ## ========================================== - Coverage 35.90% 35.21% -0.70% ========================================== Files 79 80 +1 Lines 5283 5387 +104 ========================================== Hits 1897 1897 - Misses 3386 3490 +104 ``` | [Impacted Files](https://codecov.io/gh/SiLab-Bonn/basil/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn) | Coverage Δ | | |---|---|---| | [basil/HL/tektronix\_tds3034b.py](https://codecov.io/gh/SiLab-Bonn/basil/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn#diff-YmFzaWwvSEwvdGVrdHJvbml4X3RkczMwMzRiLnB5) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

leloup314 commented 1 year ago

Thanks! Can you have a look at the flake8 ?

dschuechter commented 1 year ago

flake8 is now fixed.

I will look after flake8 in future PR's :sweat_smile:

leloup314 commented 1 year ago

Thank you! Looks good!