search

SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

Flowmeter #197

Closed AntonioT7 closed 5 months ago

AntonioT7 commented 1 year ago

Improvement on https://github.com/SiLab-Bonn/basil/blob/development/basil/HL/bronkhorst_elflow.py

leloup314 commented 1 year ago

Nice, to link an issue on basil, simply put the pound sign and the corresponding issue number e.g. #83

AntonioT7 commented 1 year ago

83

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -2.57 :warning:

Comparison is base (26fcc9f) 35.90% compared to head (acd5d13) 33.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #197 +/- ## ========================================== - Coverage 35.90% 33.33% -2.57% ========================================== Files 79 84 +5 Lines 5284 5691 +407 ========================================== Hits 1897 1897 - Misses 3387 3794 +407 ``` | [Impacted Files](https://codecov.io/gh/SiLab-Bonn/basil/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn) | Coverage Δ | | |---|---|---| | [basil/HL/bronkhorst\_elflow.py](https://codecov.io/gh/SiLab-Bonn/basil/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn#diff-YmFzaWwvSEwvYnJvbmtob3JzdF9lbGZsb3cucHk=) | `0.00% <0.00%> (ø)` | | | [basil/HL/julaboFP50.py](https://codecov.io/gh/SiLab-Bonn/basil/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn#diff-YmFzaWwvSEwvanVsYWJvRlA1MC5weQ==) | `0.00% <0.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://codecov.io/gh/SiLab-Bonn/basil/pull/197/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SiLab-Bonn)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

YannickDieter commented 5 months ago

@matthias-schuessler I guess this is needed for our module qc. Can you please check so that we can merge that too?

YannickDieter commented 5 months ago

Closed in favor of #220