search

SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

serial and visa baud rate init parameter compatibility #209

Closed mjmucha closed 5 months ago

mjmucha commented 9 months ago

Currently the baud rate init parameter is set for the serial transfer layer using baudrate and for the visa transfer layer using baud_rate.

This pull request makes these two variants interchangeable for the serial and the visa transfer layer with the aim to improve the consistency of the interface

YannickDieter commented 5 months ago

Please rebase to check if pipeline is now working.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 32.65%. Comparing base (d3cd239) to head (feaa8df). Report is 5 commits behind head on master.

:exclamation: Current head feaa8df differs from pull request most recent head 15d3a5e. Consider uploading reports for the commit 15d3a5e to get more accurate results

Files Patch % Lines
basil/TL/Serial.py 0.00% 3 Missing :warning:
basil/TL/Visa.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #209 +/- ## ========================================== - Coverage 32.67% 32.65% -0.02% ========================================== Files 85 85 Lines 5800 5806 +6 ========================================== + Hits 1895 1896 +1 - Misses 3905 3910 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.