search

SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

Improvements for mercury driver #213

Closed SilasM2001 closed 5 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 31.48%. Comparing base (92d4147) to head (4480251). Report is 49 commits behind head on master.

Files Patch % Lines
basil/HL/mercury.py 0.00% 43 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #213 +/- ## ========================================== - Coverage 32.67% 31.48% -1.20% ========================================== Files 85 87 +2 Lines 5800 6026 +226 ========================================== + Hits 1895 1897 +2 - Misses 3905 4129 +224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

YannickDieter commented 5 months ago

Please rebase to check if pipeline is now working.

YannickDieter commented 5 months ago

Thanks for the update. Actually we still should replace the prints with proper loggers like it is done for example here

cbespin commented 5 months ago

Since quite some lines are added that are not (can not?) be covered by tests, the coverage decreases, but we should ignore that.

YannickDieter commented 5 months ago

Yeah, this was also my thought. So lets merge ;)