search

SiLab-Bonn / basil

A data acquisition framework in Python and Verilog.
BSD 3-Clause "New" or "Revised" License
40 stars 29 forks source link

Small refactoring changes to USBBinds.py #226

Closed mjmucha closed 4 months ago

mjmucha commented 4 months ago

This PR includes mostly small refactoring changes. It also includes a fix in line 109 (query_identification() does not have the argument verbose anymore).

cbespin commented 4 months ago

Do you need any verbose arguments if you use 90% of them with log.info anyway? I would claim this is the preferred way, because if users want verbose info, they should enable logging on debug level. But I am open to discussions.

mjmucha commented 4 months ago

I'm kinda used to implement some functions with verbose arguments, due to how e.g. scikit-learn and other machine learning libraries are often structured. However, I really have no preference here and am open to changing the code.

cbespin commented 4 months ago

Sounds like we need a third opinion @YannickDieter @leloup314 :D

leloup314 commented 4 months ago

I think one should stick to logging for this use case. There is a reason scikit-learn use a dedicated keyword argument for this but its overkill here.

mjmucha commented 4 months ago

The PR now uses purely logging and should be ready for merging.