Track fitting enhancements

SiLab-Bonn / beam_telescope_analysis

Beam Telescope Analysis (BTA) is a testbeam analysis software written in Python (and C++)

MIT License

5 stars 1 forks source link

Track fitting enhancements #2

Closed YannickDieter closed 5 years ago

YannickDieter commented 5 years ago

Several small enhancements for track fitting:

allow min_track_hits for track hit selection
chi2 calculation for Kalman Filter
separate merged flag from quality flag
Sanity checks for KF covariance matrices

TODO:

[x] check branch with high density tracks
[x] check if Kalman filter requires different settings for track selection (e.g. minimum track hits >= 2)

Remark: increased minimum track hits to 3 for Kalman fit - lowers CPU time

YannickDieter commented 5 years ago

Can be merged, if you are fine with the changes @laborleben.

laborleben commented 5 years ago

If select_isolated_track_duts and select_isolated_hit_duts are None, should the default value be copied from select_quality_duts? Right now is is not set at all.

YannickDieter commented 5 years ago

If select_isolated_track_duts and select_isolated_hit_duts are None, should the default value be copied from select_quality_duts? Right now is is not set at all.

Good point. I would say this is the only thing one could do (besides setting all or none of the duts). But using select_quality_duts would be the best in my opinion.