search

SiLab-Bonn / beam_telescope_analysis

Beam Telescope Analysis (BTA) is a testbeam analysis software written in Python (and C++)
MIT License
5 stars 1 forks source link

Voronoi plots are not compatible with numpy>=1.24.0 #34

Open lschall opened 1 year ago

lschall commented 1 year ago

With updating to numpy 1.24.0 (see release information) numpy finally expired the deprecation for ragged/inhomogeneous (see here). For the voronoi plots we are generating in the efficiency plotting e.g. here we are using matplotlib.patches which needs a ragged array of the form [[x, y], height, width] as input see here for matplotlib.patches documentation. This will cause the script to fail for latest numpy versions. So far I have not found a way to fix this other than limiting numpy<1.24.0. Maybe matplotlib will adapt to this (not so new) numpy version soon?

YannickDieter commented 11 months ago

Any update @lschall ?

lschall commented 11 months ago

Will look into it this week again, sorry.

leloup314 commented 11 months ago

This is fixed in unit_tests branch by fixing the respective versions

YannickDieter commented 11 months ago

Thanks! did not know that you pushed to this branch I used before

lschall commented 11 months ago

I am aware of this. I was planning to adapt the plot to be able to run on numpy>1.23

leloup314 commented 11 months ago

I made a PR before ;)

leloup314 commented 11 months ago

Which was open for 2 weeks and merged yesterday

YannickDieter commented 11 months ago

Okay, sorry now I got it! Let me know when you are ready to merge to master :)