search

SiLeBAT / BfROpenLab

BfR KNIME extensions (FoodChain-Lab, KNIME Nodes for GIS and Graph Visualization, KNIME Nodes for Nonlinear Regression, BfR Network Mining Extensions, PMM-Lab Lite)
http://silebat.github.io/BfROpenLab/
GNU General Public License v3.0
7 stars 8 forks source link

Deprecating internal utility class Pair #338

Open miguelalba opened 7 years ago

miguelalba commented 7 years ago

The project de.bund.bfr.knime contains the utility class Pair. The Apache commons lang library (already included with KNIME) has a similar class https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/tuple/Pair.html.

I would suggest to remove all the usages of this class and replace it with the Apache one.

mfilter commented 7 years ago

Hi Miguel,

I have no problems with that provided you test the new version thoroughly. You can also ask Octavio to help you with the testing, as he also has some old PMM-Lab workflows. BR, MF

miguelalba notifications@github.com 14.08.17 15.51 Uhr >>> The project de.bund.bfr.knime contains the utility class Pair. The Apache commons lang library (already included with KNIME) has a similar class https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/tuple/Pair.html.

I would suggest to remove all the usages of this class and replace it with the Apache one.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/SiLeBAT/BfROpenLab/issues/338 //// 15 Jahre BfR - Wissenschaft im Dienst des Menschen ////