search

SiLeBAT / BfROpenLab

BfR KNIME extensions (FoodChain-Lab, KNIME Nodes for GIS and Graph Visualization, KNIME Nodes for Nonlinear Regression, BfR Network Mining Extensions, PMM-Lab Lite)
http://silebat.github.io/BfROpenLab/
GNU General Public License v3.0
7 stars 8 forks source link

Update copyrights #459

Open ruegenbfr opened 4 years ago

dieterdreist commented 4 years ago

not sure if this is the right issue, but I’d like to point out that the background map is from OpenStreetMap and requires attribution: https://www.openstreetmap.org/copyright thank you

dieterdreist commented 4 years ago

Any news? do you acknowledge the issue?

afalenski commented 4 years ago

Ah, sorry for not answering right away. The map view of the Tracing View node of the FoodChain-Lab Desktop App uses OpenStreetMaps. You can find "(c) OpenStreetMap contributors" in the corner of the map and when you click on this link you will be forwarded to the OpenStreetMap Website. Could you please explain what in addition you mean with "requires attribution"?

dieterdreist commented 4 years ago

great you have implemented the attribution, but I do not get to see it, see this screenshot: Screenshot 2019-11-14 at 14 41 43

dieterdreist commented 4 years ago

the screenshot above is from Firefox, also on Safari I do not see it: Screenshot 2019-11-14 at 14 44 29

bfrgottscma commented 4 years ago

We have two versions of FCL: In the desktop version OSM is referenced correctly as afalenski mentioned. In the web app (another board on GitHub) this is not done so far. Thank you for this valuable hint. We will add the reference to the web app as well. I am creating an issue right now in the web app board and this issue will be handled with high priority.

bfrgottscma commented 4 years ago

https://github.com/SiLeBAT/fcl-client/issues/234

afalenski commented 3 years ago

Copyright is visible in the TracingView and contains a link to the OpenStreetMaps webpage. Done.

Tested on Windows 10 FoodChain-Lab 1.1.38.202105261110