search

SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Makes files associated to FSKX model visible in port object #1066

Closed ahmadswaid closed 1 year ago

ahmadswaid commented 1 year ago

https://github.com/RakipInitiative/ModelRepository/issues/385

ahmadswaid commented 1 year ago

@schuelet Thanks for the hint, implemented! please have another review

ahmadswaid commented 1 year ago

@schuelet no duplication/ adding file to inherited list of resources without clearing it is possible. I tried my best to test the cases. please have another look.

schuelet commented 1 year ago

@schuelet no duplication/ adding file to inherited list of resources without clearing it is possible. I tried my best to test the cases. please have another look.

@ahmadswaid in the latest commit, the editor seems to clear everything from the "Resources List" tab. Chaining two editors also removes all entries, regardless whether I added any files or not. In fact, connecting any node, e.g. a Simulation Configurator to a Reader removes all entries. Maybe it is best to put this ticket on ice and focus on more important ones. Too bad, it seemed we almost had a working solution, if it weren't for the "add file" use-case.