Editor bug switching model category in js view does not change view

SiLeBAT / FSK-Lab

FSK Lab

https://foodrisklabs.bfr.bund.de/fsk-lab/

GNU General Public License v3.0

2 stars 4 forks source link

Editor bug switching model category in js view does not change view #1068

Closed ahmadswaid closed 1 year ago

ahmadswaid commented 2 years ago

https://github.com/RakipInitiative/ModelRepository/issues/305

With this commit and PR, I remove the "Close & Apply" on changing the model class. This way we are sure that the user have only the chance to cancel or save the setting as a new defaults. and witht his we garantuee that the model class is transfered to the dialog.

@mfilter @schuelet if you agree on the suggested solution, I will next test it on the Knime server.

schuelet commented 1 year ago

@ahmadswaid : Found two minor bugs:

On switching the model category, the creation date is reset to tt.mm.jj
On switching to Dose-Response Model or switching from Dose-Response-Model, the model name is removed:

ahmadswaid commented 1 year ago

@schuelet solved mentioned issues and the model class selection after conversion. Please have another review.