search

SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Feature simulation configurator allows to add file parameters #1085

Closed ahmadswaid closed 1 year ago

ahmadswaid commented 1 year ago

Thanks @schuelet for help in preferences tutorial:

preferences: can be exported when starting KNIME as admin (sudo) copy preference.epf to /opt/knime/knime_server/workflow_repository/config/client-profiles/executor replace with executor.epf add lines to knime.ini (/opt/knime/knime_server/knime_executor/knime.ini): -profileLocation http://127.0.0.1:8080/knime/rest/v4/profiles/contents -profileList executor

Anyway, branch tested on my server, @schuelet could you please review this PR!

schuelet commented 1 year ago

@ahmadswaid Ok, good news, the file parameter values are now visible on local execution. On server execution, the model executes and also takes new files via "add file" upload. What is still an issue is the UI: On server execution, the button "add file" is still overlapping the file names and on clicking the details of a parameter, the information are pushed down, overlapping with the other parameters.

image
schuelet commented 1 year ago

@ahmadswaid found 2 other issues:

  1. When using the Simulation Configurator on Linux and saving a workflow, the portObject can't be opened after the Simulation Configurator (see image below). Error is: ERROR FSK Simulation Configurator JS 3:5 Unable to clone input data at port 1 (FSK object): (was java.lang.NullPointerException) (through reference chain: de.bund.bfr.knime.fsklab.nodes.environment.ExistingEnvironmentManager["entries"])
  2. Adding new files via "add file" button does seem to overwrite all other simulations with those filename values. I added a file called "conso_inputs4.csv" to a new simulation "MyNewSimulation" and yet all simulations have that file now. See json here: simulations_after_adding_new_files.txt
image
schuelet commented 1 year ago

@ahmadswaid: Tested the changes and most issues are fixed. Two issues remain:

  1. if there are more then one FILE parameters, adding only one leaves the others empty:

    image

  2. the portObject still doesn't load when opening an exported workflow on another computer.

ahmadswaid commented 1 year ago

@schuelet issue No. 1 was solved work is still in progress on issue No. 2

schuelet commented 1 year ago

@ahmadswaid The portObject Issue seems to be fixed. Unfortunately something broke with the upload, added (uploaded) files no longer appear in the workspace of the model. I checked the previous commit 42a1c05 and there the upload still worked.