search

SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Refactor method buildContainerName #426

Open miguelalba opened 4 years ago

miguelalba commented 4 years ago

The method buildContainerName is repeated in three nodes: https://github.com/SiLeBAT/FSK-Lab/blob/615e52e0735688355864e59fc835ba3e9632a07e/de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/FSKEditorJSNodeModel.java#L428 https://github.com/SiLeBAT/FSK-Lab/blob/615e52e0735688355864e59fc835ba3e9632a07e/de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/JoinerNodeModel.java#L556 https://github.com/SiLeBAT/FSK-Lab/blob/615e52e0735688355864e59fc835ba3e9632a07e/de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/JSSimulatorNodeModel.java#L357

This method should be moved to NodeUtils and tested.

schuelet commented 3 years ago

There is only one buildContainerName method left as of FSK-Lab 2.0, in the JoinerRoleModel.java class.

However I will leave this open, since this method is notoriously prone to errors when the node is wrapped in a Component.

mfilter commented 3 years ago

I suggest we create some test workflows with components that we can put into our built test pipeline