search

SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Esther Joiner 1: Joiner doesn't work if no Joining took place #472

Closed schuelet closed 3 years ago

schuelet commented 3 years ago
schuelet commented 3 years ago

issue not reproducable Edit: reproducable if Joiner View is not opened at all before model execution

schuelet commented 3 years ago

As of FSK-Lab 2.0 this is only happening if a Joiner is simply executed without opening the View once. The models don't actually need a connection, but the View needs to be opened. @ahmadswaid Do you think this is worthwhile?

https://app.zenhub.com/files/73478810/570a0054-6a8c-4fca-9781-8a1cf6475f8e/download?

mfilter commented 3 years ago

a "joining" of models without opening the view should work even if the models are not graphically connected

llavall commented 3 years ago

May I ask what the intention behind a joining without joining is? KNIME often blocks execution of a node if there is no setting done before. If the joiner should be allowed to run without a connection inside it should at least give a warning that there was no actual joining set up.

mfilter commented 3 years ago

This is a desired feature to simply get two models executed in the same R workspace. A warning would of course not harm, but this was not the issue reported here.

mfilter commented 3 years ago

at least for me the Joiner works, but the Runner creates a NPE. knime://BfR-extern/FSKX_Testing/FSK-Lab_2.0/broken_workflows/20210412_Test_JoinerWithoutGraphicalJoining_MF

schuelet commented 3 years ago

fixed as of https://app.zenhub.com/workspace/o/silebat/fsk-lab/issues/854