SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Joiner Node Refactoring #662

Closed ahmadswaid closed 3 years ago

ahmadswaid commented 4 years ago
mfilter commented 4 years ago

the Joiner node also has to create combined simulation settings for the joined model. It should be defined how this combination is performed. In an ideal solution the user has somewhere the chance to define this, e.g. a) combine just the default simulation scenario from each base model or b) create automatically a combination of all existing simulation scenarios from each base model or c) select individual simulation scenarios from each base model that are then combined.

mfilter commented 4 years ago

I suggest to add a dedicated ticket with a list of test workflows that need to be established for this node.

mfilter commented 4 years ago

Doesn't this node need to be able to emit an event as well? After the joining is accomplished the newly created joined metadata should become editable in the Joiner component

ahmadswaid commented 4 years ago

The Idea proposed on giving the user the option to select the simulation merging strategy looks good but what will happen if the user chooses the second option of "automatically a combination of all existing simulation scenarios" and each model has a different number of scenarios provided?

mfilter commented 4 years ago

then you "multiply" those scenarios, i.e. model A and B have 2 scenarios each then the combined model has 4 scenarios.