SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Joiner does not concatenate metadata #819

Closed mfilter closed 3 years ago

mfilter commented 3 years ago

Please have a look into the following test WF: knime://BfR-extern/FSKX_Testing/FSK-Lab_2.0/broken_workflows/Test_MF

As you can see the metadata of the joined model is a wired mixture from both input models where a lot of the metadata (e.g. authors, creators, references) are missing. Also the expected concatenation of titles, names, scope is not available.

schuelet commented 3 years ago

Can confirm, only the model name has the concatenation.

schuelet commented 3 years ago

@ahmadswaid if the whole concatenation is not implemented, the easiest way to do it I think is in JavaScript:

` function isArray(what) { return Object.prototype.toString.call(what) === '[object Array]'; } for(var i in json) {
if(isArray(json[i])) { // concatenate array } else { // concatenate string } }

`

The biggest challange is to check if the element is of controlled vocabulary, then I guess we take the entry of the last model

ahmadswaid commented 3 years ago

@schuelet, I agree with you on that if there is no other concerns related to concatenation of models metadata of deffirent model classes.

schuelet commented 3 years ago

fixed as of SiLeBAT/FSK-Lab#825