SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Editor JS view - corrupted display of scripts, missing visualization of images, poor handling of temp folders #839

Closed mfilter closed 3 years ago

mfilter commented 3 years ago

I looked into the Editor JS and found several critical issues:

ahmadswaid commented 3 years ago

@mfilter:

mfilter commented 3 years ago

re point 2: we can ignore this point. I had mixed up things here. re the folders: confirmed. Maybe @llavall can check how KNIME handles these folders on the server. Maybe there it is not a problem with that as these folders are deleted once a job is discarded. I don't know how we handle these folders on the server.

llavall commented 3 years ago

I only see 3 folders with the name knimeView* on the internal server in /tmp even after opening a KNIME View. I assume KNIME is reusing these folders on the server? But the /tmp folder is full of all kinds of folders and files which seem to be created by FSK and not deleted afterwards (R, SMBL, etc.). I assume itshould fix all problems at once if we could on the server write all files in the workflows temp directory.

mfilter commented 3 years ago

Could you please be more specific on the folders you see? In this ticket we should focus on the folders that are linked to the JS views. We have another ticket open for the folders created by the FSK Runner

llavall commented 3 years ago

I can not say where the folders and files are derived from. For the mentioned knimeView* folder I only see 3 - and they seem to be reused. Maybe we can look at these files and folders together in the webmeeting and the developers give some insights.