search

SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

Marcel Editor 1: Editing entries in Scope not working #860

Closed Thatsreallycool closed 3 years ago

Thatsreallycool commented 3 years ago

Adding entries via Editor in "Scope->Product", "Scope->Hazard", "Scope->Population group" works fine, but editing entries once saved do not lead to the Editing pop-up window.

Tested on existing models and a simple Editor with test entries with the same outcome

editor

schuelet commented 3 years ago

Here is a workflow showcasing the issue. It seems some missing values cause a null pointer exception. knime://external-KNIME-Server/FSKX_Testing/FSK-Lab_2.0/broken_workflows/editor_bug_editing_in_scope

image.png

ahmadswaid commented 3 years ago

@filter I have already solved it in https://github.com/SiLeBAT/FSK-Lab/pull/863, I was waiting to @schuelet to close the current ticket

mfilter commented 3 years ago

Marcel just tested it and for him it did not work. I assign Marcel now as well.

mfilter commented 3 years ago

Maybe you could have a web meeting to clarify

ahmadswaid commented 3 years ago

@mfilter I don't if @Thatsreallycool tested it on a build which contains the fix. anyway trying to contact him.

mfilter commented 3 years ago

@Thatsreallycool : please confirm that this issue is solved with the latest built

Thatsreallycool commented 3 years ago

tested this on https://gitlab.bfr.berlin/silebat/repositories/raw/master/fsklab/

with this build this bug is not encountered. Before closing this ticket, i would suggest to wait until this can be tested on "test".

mfilter commented 3 years ago

seems to work now. I close this ticket. Great!