search

SiLeBAT / FSK-Lab

FSK Lab
https://foodrisklabs.bfr.bund.de/fsk-lab/
GNU General Public License v3.0
2 stars 4 forks source link

check if validation errors exists before manipulating #931

Closed ahmadswaid closed 3 years ago

ahmadswaid commented 3 years ago

https://github.com/RakipInitiative/ModelRepository/issues/346

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit a88e9400 and detected 0 issues on this pull request.

View more on Code Climate.

schuelet commented 3 years ago

@ahmadswaid Can you explain what you did here? It doesn't look like much has changed, why did only the models from that workflow throw this error?

ahmadswaid commented 3 years ago

@ahmadswaid Can you explain what you did here? It doesn't look like much has changed, why did only the models from that workflow throw this error?

it seems that models in this workflow have not issue with the metadata so validation map was null so that it was giving an error when saving. do you see the changes in the app_1.0.0.js It could be that you need to to trigger a maven build on the de.bund.bfr.knime.js project to have the bundle generated again.

schuelet commented 3 years ago

@ahmadswaid Oh, no, it did work fine, I was just wondering what the issue was. Thanks for clarifying that.