SiLeBAT / mibi-parse-cloud

MIT License
0 stars 0 forks source link

As an Administrator I want to be able to load AVV XML catalogues onto the host machine so that they can be read when the server restarts #5

Closed dptolle closed 3 months ago

dptolle commented 8 months ago

As an Administrator I want to be able to load AVV XML catalogues onto the host machine so that they can be read when the server restarts.

The upload should be available via the parse dashboard. Uploading should automatically convert the XML into the required json format. Failure to convert should delete the file and remove the entry fmor the db. Deletion via the dashboard should also delete the created json. Success should be logged as well as displayed as a popup. Failure should also be logged.

dptolle commented 8 months ago

@afalenski Does this ticket cover everything we want to implement in the first instance?

dptolle commented 8 months ago

@afalenski For a complete test a server restart is required, however you can start by testing upload and deletion. I have only tested it with a small file (avv303). 'catalogueFile' is a required field. All else the programm should read from the file if available. The file content acts as the ultimate source of truth and will overwrite administrator added version and catalogueCode. You should be able to override the validFrom. Is this the way you want it? Also see if a longer upload (of a larger file) causes the frontend to become unresponsive - it shouldn't

afalenski commented 7 months ago

@dptolle In catalogue 324 the version is in row 672. Could this perhaps be the reason for the bug? In other catalogues the version is in row 13 or 15.

grafik.png

Overall opinion: It is a good start (see first bullet point). If errors happen I would like to be informed in more detail and I would like to be able to display the JSON file (in a browser tab or as download). Thus, if there is a strange reaction to a Einsendebogen test file I could check in the JSON file whether the entry is there and whether it is correct. This might rule out some reasons for the error and shorten the time for the developer to solve a bug ticket.

dptolle commented 7 months ago

@afalenski Please test again. You still won't be able to see the JSON file through the Dashboard interface - this is a bug caused by our unusual deployment configuration. It might be fixed in the future, once the parse server is fully operational. In the mean time there is a work-around I will show you next time we meet.

afalenski commented 6 months ago