Closed soroushysfi closed 4 years ago
NIT: me and Kevin should be tagged under Reviewers
instead of Assignees
.
The first one looks good.
The middle one, the pie chart,
rating
instead of ranking
.Same reason for the 3rd bar chart, use the line plot to show 18 years of genres. The movie genres are listed in the README file along with the dataset:
* Action
* Adventure
* Animation
* Children's
* Comedy
* Crime
* Documentary
* Drama
* Fantasy
* Film-Noir
* Horror
* Musical
* Mystery
* Romance
* Sci-Fi
* Thriller
* War
* Western
* (no genres listed)
we should still be able to merge this PR since this react app worked without any issue, and we can always add or change visualizations on the fly.
Okay we can merge this not as "done-done" but "working-done". Are we going to follow this up with more PR on the plots? becoz right now only the 1st and last bar charts are demo-able, and the 2nd pie chart series would be unpresentable with 20 years of data in it.
@superliuxz @soroushysfi We could create an issue with high priority regards to the need of having an efficient way of presenting the rating differences in 20 years.
@superliuxz @soroushysfi We could create an issue with high priority regards to the need of having an efficient way of presenting the rating differences in 20 years.
Sure, but my overall concern is that currently, we only have two presentable bar charts. How many more plots do we want? what are they? Who is going to work on what (I know Javascript but not familiar with D3 so can't really help too much; also depends on how complicated the query is I might have to do further changes to the db schema, indexing etc.)? Do we reach a consensus on what to present (i.e., is each plot meaningful at all? IMHO the ratings distribution across the years
bar charts needs to be further synthesized. I am not aware of the value out of it, and if there is, we need to present it with better graphics, hence I proposed the line char which is easier to see the trend of each rating distribution).
I agree with the line chart. I can change the pie chart section to line plot like the one you put link to. I'll start working on that. Can you guys share the APIs, so that I can connect real data to frontend.
@superliuxz I think the ideas are discussed in the issue section and for the table/chart/plot d3 part, I could help @soroushysfi as much as I can. I am also posting my ideas to be presented in the issue section.
I've added 3 different charts. they are working fine. Only thing needed to make them look real is the data. Whenever APIs gets ready I will make the http request from frontend. feel free to add any comments.