search

SiRumCz / CSC501

CSC501 assignments
0 stars 1 forks source link

Extra charts added #20

Closed soroushysfi closed 5 years ago

soroushysfi commented 5 years ago

I added line chart and word cloud. happy to know your comments.

soroushysfi commented 5 years ago

@superliuxz That seems awesome, If it's not too much work. @SiRumCz Can you please review this PR so that I can continue?

superliuxz commented 5 years ago

@superliuxz That seems awesome, If it's not too much work. @SiRumCz Can you please review this PR so that I can continue?

That's not, as long as we are clear on one specific goal, things are pretty straightforward. My PR should be ready in less than 1-2 hours, at most 3.

superliuxz commented 5 years ago

@superliuxz That seems awesome, If it's not too much work. @SiRumCz Can you please review this PR so that I can continue?

That's not, as long as we are clear on one specific goal, things are pretty straightforward. My PR should be ready in less than 1-2 hours, at most 3.

My PR is up: GH-23. If you want you can append another commit in your (this) PR, where you can hook up the four charts to the four endpoints. Let me know if you are having troubles on anything, including bring the changes from my feature branch to your feature branch, if you decide to hook up the endpoints.

soroushysfi commented 5 years ago

@superliuxz That seems awesome, If it's not too much work. @SiRumCz Can you please review this PR so that I can continue?

That's not, as long as we are clear on one specific goal, things are pretty straightforward. My PR should be ready in less than 1-2 hours, at most 3.

My PR is up: GH-23. If you want you can append another commit in your (this) PR, where you can hook up the four charts to the four endpoints. Let me know if you are having troubles on anything, including bring the changes from my feature branch to your feature branch, if you decide to hook up the endpoints.

I think it's better if we merge these branches first. Thanks for the quick update.

superliuxz commented 5 years ago

@superliuxz That seems awesome, If it's not too much work. @SiRumCz Can you please review this PR so that I can continue?

That's not, as long as we are clear on one specific goal, things are pretty straightforward. My PR should be ready in less than 1-2 hours, at most 3.

My PR is up: GH-23. If you want you can append another commit in your (this) PR, where you can hook up the four charts to the four endpoints. Let me know if you are having troubles on anything, including bring the changes from my feature branch to your feature branch, if you decide to hook up the endpoints.

I think it's better if we merge these branches first. Thanks for the quick update.

SG. I am fine with either. Thanks.