Closed jonhealy1 closed 4 years ago
please remove .DS_Store
hidden folders, and create a folder videos
to include them. thanks
Why do they keep showing up? I have no idea where they are.
I believe this is a MACOS thing. it creates it for some purposes.
please create videos
folder to put them.
I feel like you don't want me in this group. You have never checked out one thing I've worked on and now you're being overly critical.
I spent a full 2+ days working on this and you now can't check out the videos because they're not in a videos folder?
Thanks for the videos. I'll embed them in our webpage and write the details you said as a description for them.
I feel like you don't want me in this group. You have never checked out one thing I've worked on and now you're being overly critical.
I am truly sorry, this is certainly not what I meant. Please accept my apology for making you to think this way. As a computer science student, I just want to make sure our work to be nice and clean, so I forced our group to follow certain standards for coding styles to improve maintainability and readability. If this bothers you, you can just include everything in your branch without merging into the master. I insisted doing this because of the other member(William), I value his work experience and I would want to learn from him.
Also I have checked the video you mentioned on Wednesday with Soroush and we were amazed by the idea and also some unclear details we would like to discuss with you. And since I don't have much knowledge about visualization techniques and framework than you and Soroush, I usually just come to see Soroush in person to ask my questions and present my ideas.
So even though I have transferred the ownership of this repo, it seems that I can still see the updates from this repo on my Github feed (a lot actually lol).
@noonespecial009 Hey Jonathan, I am William. I was part of this team and I had to quit because some personal errands. I used to own this repo.
@noonespecial009 I just want to state my very humble opinion here. I don't think @SiRumCz really meant anything else other than maintaining the good engineering practise. Speaking from my very limited experience, practising good coding / engineering habits always benefits in the long run. Yes I understand that these things are almost nitpicking.
There are different school of thoughts on how should a team practise the coding style. There is not really right or wrong here. IMO as long as the team can reach a consensus and working strictly according to it, it's then a good engineering practise.
It might be okay to have three videos parallel in the "root" directories. But how about 6 videos? 12 videos? I think this is what @SiRumCz was getting at. I am with @SiRumCz here, and I do think it's cleaner to have a separate videos
directory for the .mp4
files. I also suggest do it one step further, to have the videos
directory under visualization
directory., because I would imagine these videos are presented on the front end.
@SiRumCz I also think, next time, when you make such suggestions, state your reasoning. Concretely:
please create
videos
folder to put them.
can be better as:
please create
videos
folder to store them under, because blah blah blah ...
I recalled that I failed to do this in assignment 1, which created certain confusion.
Also, the .DS_Store
is a file generate by MacOS. It stores the meta info about the current directory. You won't see them because any file/dir starting with a .
is hidden for *nix systems. For anybody who is using a Mac, I strongly advice adding .DS_Store
entry in your global .gitignore
file. You can google more information on this.
Hi everyone. I understand the need to be neat. @SiRumCz is always telling me he will check out something that I did later and then I don't hear from him again. Try something like: "Videos look great, we should put them in a videos folder." I asked you if you could check out one of the other videos that I made a few days ago and then you said you would check it out later that day and I never heard from you. I also made some super cool heat maps that I didn't hear anything from you about and am not sure if we should move ahead with them. You also said you would check out the notebook I was working on but again ... it's been over a week and nothing. @superliuxz Thanks for the advice. Nice to hear from you.
I feel like you don't want me in this group. You have never checked out one thing I've worked on and now you're being overly critical.
I am truly sorry, this is certainly not what I meant. Please accept my apology for making you to think this way. As a computer science student, I just want to make sure our work to be nice and clean, so I forced our group to follow certain standards for coding styles to improve maintainability and readability. If this bothers you, you can just include everything in your branch without merging into the master. I insisted doing this because of the other member(William), I value his work experience and I would want to learn from him.
Also I have checked the video you mentioned on Wednesday with Soroush and we were amazed by the idea and also some unclear details we would like to discuss with you. And since I don't have much knowledge about visualization techniques and framework than you and Soroush, I usually just come to see Soroush in person to ask my questions and present my ideas.
Don't merge on to the main branch? Because there are three videos not in a videos folder? What are the unclear details you want to discuss about? I'm not bothered about being neat! I'm bothered because you always say that you will look at what I have done and then I never hear from you. You can't merge this branch or say anything nice about my videos because they're not in a folder - ok.
Hi everyone, I thought about the misunderstanding just happened here. From what I can see the issue we're having is mostly from miscommunication. When we talk over GitHub, slack, and whatever tool we use to communicate, we try to be straight and cut to the chase and skip whatever unnecessary. This may cause some misunderstanding and even our audience would miss-interpret our tone. Secondly in my opinion whenever we want to show someone a better way to do something, it's better if we take it in action instead of telling others what to do. This would give out a sense of collaboration. For our situation here I know that Kevin really wants Jonathan to be in our group because when Sean asked us if we wanted to have Jonathan as our new member, Kevin insisted on inviting him into our group because the more people we have, the more ideas we would have to do our assignments. Also I've talked to Kevin a few times(we have standup meetings in our office and we see each other almost every day) about the assignment and talked about the video as well. I am sure that the problem here is caused by the way we communicate and it's better if we give each other constructive feedbacks and notice what are others doing. I think whatever we say here it's only because we want to learn more and do as good as we can, it's nothing personal.
I added 3 videos one at zoom level 13, one at 12 and one at 11. I haven't embedded them yet on our page. I think we should use all 3 of them.
The size of the circle is the total amount of traffic - arrivals + departures. The circle is orange if there are more departures and blue if there are more arrivals.
The videos are in the Assignment 2 folder. I think we should just have them all auto playing on loop. They're pretty small files.