search

SiRumCz / CSC501

CSC501 assignments
0 stars 1 forks source link

3 visualizations running #83

Closed jonhealy1 closed 4 years ago

SiRumCz commented 4 years ago

I think we should leave it as it is right now, since it is a demo branch for the visualization. Once we are able to generate correct data, we can merge the whole thing together.

jonhealy1 commented 4 years ago

Ok sounds good. I wanted to make a pull request and didn't know if we should merge this first.

SiRumCz commented 4 years ago

It's fine, we could just leave it here.

soroushysfi commented 4 years ago

I think PRs should be made by the people who make the branch. Because since Sean extended the deadline I tried to work on the visualization again and if this branch got merged I would've lost all my changes.

jonhealy1 commented 4 years ago

I think PRs should be made by the people who make the branch. Because since Sean extended the deadline I tried to work on the visualization again and if this branch got merged I would've lost all my changes.

Sorry. I wanted everything on one branch so I could try to work on the graphs too. Couldn't you just push your changes to a new branch - I'm far from a git expert. Merging my branch ahead of your branch may have put you in the same predicament anyways. I didn't hear from you all day so I just assumed you were busy with something else...

jonhealy1 commented 4 years ago

Next time I'll make sure to ask you or just wait. Did you figure anything out?

soroushysfi commented 4 years ago

I didn't push my changes because they're still not stable and need some refinement. I am still having trouble with the matrix and I am trying to change the chord diagram a bit and make it more interactive. I will switch to cypher immediately again to help you guys.