search

SiTingST / pe

0 stars 0 forks source link

Invalid error message for edit #6

Open SiTingST opened 3 years ago

SiTingST commented 3 years ago

It states that "edit 5 Wednesday" is an invalid index however the index 5 has been assigned to a student as seen below.

image.png

nus-pe-bot commented 3 years ago

Team's Response

The format keyed in is incorrect. The index will be parsed up to the point where the first prefix is detected in the input command string. Hence in this case the index that u keyed in will be "5 Wednesday". So the error message is indeed correct.

The proper way to input this command and perhaps get an error message for the lesson day is edit 5 le/wednesday, or edit 5 le/wednesday 1500 for a completely valid input.

The chances of this error occurring is very low if the user follows our user guide, hence severity should be Very Low.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even though the input is incorrect, the error message does not reflect the problem of a missing prefix when other fields in the command are entered correctly. For i.e. the main problem with the command: edit 5 Wednesday lies in it's missing prefix. However, the error message shown indicates an invalid index instead. As seen in the screenshot above, number 5 is a valid index in the list.

Hence, it is a valid bug since the error message does not target the real error in the command provided and instead misleads the user.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This happens for ALL edit commands entered without a prefix. Some screenshots of the edit command entered without a prefix which displays the same error message is shown below.

image.png

image.png Capture.PNG

As it is a prevalent problem that persists for all variations of the Edit command, the reduction of severity to Very Low seems to be unjustified. Even though the user read the user guide, it is unlikely that they can remember the correct input format for each command. Very often, users do not refer to the user guide each time they use the program. Hence, it is important that error messages are displayed are correct and matches/targets the real error.