search

SiTingST / pe

0 stars 0 forks source link

Incorrect schedule timetable #9

Open SiTingST opened 3 years ago

SiTingST commented 3 years ago

Adding a student with a lesson and deleting the addressbook.json file did not update the list of schedule.

Steps to reproduce the bug:

add n/Tammy p/17654321 s/Def Secondary School a/Bob street, block 321, #01-02 gn/John Lee gp/12345678 t/geo le/tuesday 1700

delete the addressbook.json

When schedule command is entered, the app will still show the lesson that tammy has even though she is no longer shown as a student in the list panel.

image.png

nus-pe-bot commented 3 years ago

Team's Response

Under the "Editing the data file" section in our UG, we stated that users are discouraged from editing the data files directly due to syncing issues between the three files.

image.png

The tester encountered an error because they deleted "Tammy" from the addressbook.json file but not the lessonbook.json file, against our warnings. Thus, we will not accept this as a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As testers are allowed to edit the JSON file directly during the PE, as seen in the screenshot below and, the team did not implement proper error handling to ensure that students who have been assigned a lesson in the lessonbook.json should also exist in addressbook.json. This bug has occurred and hence, is a valid bug.

Discouraging the users from editing the JSON file in the UG is also not a strong enough reason to reject this bug as making changes to the JSON file is within the scope of the PE.

prof.PNG

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: It is likely that the team did not implement proper error handling for problems arising by editing the JSON data across the different JSON files. This is potentially a bigger issue as they have 3 different JSON files and data across the different JSON files are not cross-checked against one other, even when needed. As a result, this might break certain constraints for i.e. allowing the user to assign lessons to students, not listed in the application.