search

SiaFoundation / app-sia-x

(WIP) Sia App for Ledger Nano X
MIT License
7 stars 4 forks source link

Stax Port #2

Closed chris124567 closed 1 year ago

chris124567 commented 1 year ago

Port UI flow to new NBGL library, add UI tests using ragger, and add go.mod stuff for sialedger.go as go now requires modules.

chris124567 commented 1 year ago

It seems like a lot of these issues are either minor or were preexisting (typos, we don't have doxygen documentation, etc). I'll fix them anyways because it makes the review process go faster :+1:

chris124567 commented 1 year ago

OK I think all the things that could be addressed from the CI failures have been addressed. We don't have doxygen documentation, the "typos" that remain are all false positives due to the flagg library, we don't have unit tests, the static analyzer errors are just because the txn_state_t struct uses uint_t instead of char types to be exact, and I don't think we ever supported the NanoSP (?).

chris124567 commented 1 year ago

If there's no other problems I guess this can be merged? Unless we want to have Ledger review it in this PR. The only remaining (minor) issue is the app database load parameters but we can't control that here anyways.

chris124567 commented 1 year ago

Please also consider https://github.com/SiaFoundation/app-sia-x/commit/9975369ee02fc6aaab7d37a4964a1e2067026b29 in this same stax-port branch but which for some reason doesn't show up on this page, which fixes the static analyzer warnings and adds Stax USB support to sialedger.go.