SiaFoundation / linux

The official source of all available Linux packages of Sia software
MIT License
2 stars 1 forks source link

The deb package does not conform to Debian specs #129

Open NickJH opened 2 months ago

NickJH commented 2 months ago

Current Behavior

At the moment all it seems to do is install hostd into /usr/bin, add a systemd unit file and create a /var/lib/hostd folder.

Expected Behavior

If the guidelines are followed:

Oh, and in the service file, After=network.target doesn't really mean anything although it is commonly used. Better would be After=network-online.target.

Steps to Reproduce

No response

Version

any hostd.deb package

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Ubuntu/Debian

Anything else?

Note that the Ubuntu guidelines seem to be under a rewrite. The Debian Policy Manual can be found at https://www.debian.org/doc/debian-policy/. More info at https://wiki.debian.org/Packaging.

NickJH commented 3 weeks ago

Some things have moved on a bit. Debian 12 (Bookwork) has deprecated rsyslog and is, by default, doing everything through journalctl. Ubuntu 24.04 LTS retains rsyslog by default. However, the folders /etc/rsyslog.d and /etc/logrotate.d both exist on the default Debian 12 installation, so you can still package rsyslog and logrotate configlets in a common Ubuntu/Debian package and they just won't do anything in Debian 12. The yaml file stays common between them

Obviously in the future, Debian may remove rsyslog completely, but that will be for the future and a new issue should be raised at that point.