search

SiaFoundation / walletd

A new Sia wallet
https://sia.tech/software/walletd
MIT License
14 stars 6 forks source link

Prometheus encoder added similar to hostd #56

Open bustedware opened 5 months ago

bustedware commented 5 months ago

Prometheus encoder added to walletd similar to hostd.

The /api/wallets endpoint does not appear to be working, which was not an endpoint that was modified. The endpoint returns error couldn't load wallets: transaction failed (attempt 1): no such column: friendly_name

The /api/wallet/:id/balance and /api/wallet/:id/events endpoints now reflect back the wallet :id in the response.

n8maninger commented 5 months ago

I highly recommend holding off on walletd support until we release a more stable version. The endpoints are very likely to continue changing.

bustedware commented 5 months ago

@n8maninger it seems like it was just something with the UI doing a PUT instead of POST as the endpoints defined in code. The UI is also tagging on something to the end of the URL which the method doesn't currently seem to be implemented for. Not sure which one is more correct though so I will defer to you. I was able to work around it by formatting the request properly on the command line and tested the remaining wallet Prometheus endpoints.

Screenshot 2024-02-25 175247

Might be easier get the Prometheus stuff in now and have the core team take it from here?