Sian-Lee-SA / Home-Assistant-Switch-Manager

Switch manager is a centralised component to handle button pushes for your wireless switches. This includes anything passed through the event bus. The component relies on switch blueprints which is easily made to allow GUI configuration of your switches and their button pushes. This helps remove clutter from the automations.
Other
222 stars 84 forks source link

Added ZHA Inovelli Blue switches #142

Closed nwithan8 closed 1 year ago

nwithan8 commented 1 year ago

Blueprint Checklist

Zigbee2MQTT

Sian-Lee-SA commented 1 year ago

The sizing wasn't the inital problem although thanks for changing it to the correct size (I wasn't even aware when I reviewed). It's the cropping, there needs to be no transparency outside the switch and cropped to the edges of the device within the image.

Sian-Lee-SA commented 1 year ago

Please follow guidelines! I have reviewed a few of your PR's each with inconsistent errors. You then fix the errors on one blueprint only to ignore it on others etc...

press 1x should not have 1x in it release should be hold (released)

Just note, me reviewing these also takes up my time and sometimes I can miss things but a blueprint being submitted with 2-3+ errors from a guideline perspective is a bit excessive. In future please review your PR's and compare with the guidelines posted in this repo's readme. This will save us from frustrations and help with the process.

Sian-Lee-SA commented 1 year ago

Much better, Thank you!