search

Sian-Lee-SA / Home-Assistant-Switch-Manager

Switch manager is a centralised component to handle button pushes for your wireless switches. This includes anything passed through the event bus. The component relies on switch blueprints which is easily made to allow GUI configuration of your switches and their button pushes. This helps remove clutter from the automations.
Other
225 stars 85 forks source link

Added Zigbee2MQTT Philips Hue Smart Button #95

Closed XavierG closed 1 year ago

XavierG commented 1 year ago

Zigbee2MQTT Philips Hue Smart Button blueprint

Blueprint Checklist

Sian-Lee-SA commented 1 year ago

Looks good, thank you!

Sian-Lee-SA commented 1 year ago

I'm curious, is your blueprint configured to use the device with legacy on within Z2M? If so, this will need to be changed to match legacy off. The documentation on Z2M for this device has action names different to your blueprint and I believe this is because of the legacy being on.

XavierG commented 1 year ago

That's weird. I double checked, and legacy is off. For some reason the z2mqtt page is unreachable: https://www.zigbee2mqtt.io/devices/ROM001.html

What action did you identified ?

Sian-Lee-SA commented 1 year ago

https://www.zigbee2mqtt.io/devices/8718699693985.html is the page I'm referencing, but I'm not certain how they structure their actions and data based on legacy. Some devices has legacy default to on (which is the case for this device but they clearly state that they recommend it to being off) so I'm not sure if their actions are based on legacy being on or not. It is confusing.

Edit: I'm also following this up because someone on a forum requested this device as a blueprint and completely forgot it was added in latest update so I was doing a bit of searching and noticed the actions on their docs were different so I just wanted confirm yours was tested with legacy off as thats the standard and directions I make to users who use Z2M blueprints from this repo

XavierG commented 1 year ago

Will do some testing when at home. I'm on a trip for the next couple of days. Will keep you posted.

Le lun. 13 févr. 2023, 22:48, Sian @.***> a écrit :

https://www.zigbee2mqtt.io/devices/8718699693985.html is the page I'm referencing, but I'm not certain how they structure their actions and data based on legacy. Some devices has legacy default to on (which is the case for this device) so I'm not sure if their actions are based on legacy being on or not. It is confusing.

— Reply to this email directly, view it on GitHub https://github.com/Sian-Lee-SA/Home-Assistant-Switch-Manager/pull/95#issuecomment-1428735013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSRKT6TM7K4J44DPITFXGLWXKT3PANCNFSM6AAAAAAUMNBKBI . You are receiving this because you authored the thread.Message ID: @.***>

XavierG commented 1 year ago

Ok so, we it seems we are both right:

I tried with another button I have laying around, and unfortunately, there is 2 different actions type for these buttons on long press:

skip_backward / skip_upward on one button, and brightness_step_down / brightness_step_up on another.

I also checked the model number in z2mqtt for both buttons, and it's the same (8718699693985 https://www.zigbee2mqtt.io/devices/8718699693985.html#philips-8718699693985 ).

To be honest, I don't know what to do in order to handle both types of buttons. Any suggestions?

Le mar. 14 févr. 2023 à 07:44, Xavier Gouy @.***> a écrit :

Will do some testing when at home. I'm on a trip for the next couple of days. Will keep you posted.

Le lun. 13 févr. 2023, 22:48, Sian @.***> a écrit :

https://www.zigbee2mqtt.io/devices/8718699693985.html is the page I'm referencing, but I'm not certain how they structure their actions and data based on legacy. Some devices has legacy default to on (which is the case for this device) so I'm not sure if their actions are based on legacy being on or not. It is confusing.

— Reply to this email directly, view it on GitHub https://github.com/Sian-Lee-SA/Home-Assistant-Switch-Manager/pull/95#issuecomment-1428735013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSRKT6TM7K4J44DPITFXGLWXKT3PANCNFSM6AAAAAAUMNBKBI . You are receiving this because you authored the thread.Message ID: @.*** com>

XavierG commented 1 year ago

Forgot to mention, the exact same firmware on both buttons too... So from my point of view, there is no way to differentiate them...

Le sam. 18 févr. 2023 à 18:30, Xavier Gouy @.***> a écrit :

Ok so, we it seems we are both right:

I tried with another button I have laying around, and unfortunately, there is 2 different actions type for these buttons on long press:

skip_backward / skip_upward on one button, and brightness_step_down / brightness_step_up on another.

I also checked the model number in z2mqtt for both buttons, and it's the same (8718699693985 https://www.zigbee2mqtt.io/devices/8718699693985.html#philips-8718699693985 ).

To be honest, I don't know what to do in order to handle both types of buttons. Any suggestions?

Le mar. 14 févr. 2023 à 07:44, Xavier Gouy @.***> a écrit :

Will do some testing when at home. I'm on a trip for the next couple of days. Will keep you posted.

Le lun. 13 févr. 2023, 22:48, Sian @.***> a écrit :

https://www.zigbee2mqtt.io/devices/8718699693985.html is the page I'm referencing, but I'm not certain how they structure their actions and data based on legacy. Some devices has legacy default to on (which is the case for this device) so I'm not sure if their actions are based on legacy being on or not. It is confusing.

— Reply to this email directly, view it on GitHub https://github.com/Sian-Lee-SA/Home-Assistant-Switch-Manager/pull/95#issuecomment-1428735013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSRKT6TM7K4J44DPITFXGLWXKT3PANCNFSM6AAAAAAUMNBKBI . You are receiving this because you authored the thread.Message ID: @.*** com>

Sian-Lee-SA commented 1 year ago

Are you checking the legacy off in the device pages settings (specific)? Screenshot_20230219-073544

XavierG commented 1 year ago

You're right! I forgot to check this!

So, my blueprint is correct when legacy set to false. But because it's true bu default, my 2nd try was working differently.

That being said, it means z2mqtt documentation listed Legacy actions. Shouldn't they list non legacy actions?

If so, I will propose an updated version of the doc.

Sian-Lee-SA commented 1 year ago

You'd think so, honestly I've been trying to wrap my head around their docs and this legacy stuff for a while... I can only asssume because the default is true for the device, then they advertise the legacy actions because of the default but personally I find that logic counter intuitive. You'd think they should be encouraging the move from legacy and eventually deprecate it, so it could be a lack of updated documentation or resorting to the default in which legacy is on... One way or another, the legacy crap hasn't been handled well by them.