search

SiarheiFedartsou / fastlane-plugin-versioning

Extends fastlane versioning actions. Allows to set/get versions without using agvtool and do some other small tricks.
MIT License
504 stars 60 forks source link

Add countrycode parameter to get_app_store_version_number #22

Closed d1m0nh closed 4 years ago

d1m0nh commented 6 years ago

Please add country parameter to the function get_app_store_version_number. For app`s with country restriction addition parameter should be set in the url.

http://itunes.apple.com/lookup?bundleId=#{bundle_id}&country=#{countryCode}

jdouglas-nz commented 4 years ago

@d1m0nh - how would you propose the 'default' would work? as in, if I didn't pass in a country code, what should happen to the url that is formed? the only thing I can think of is either no countrycode parameter, or perhaps there is some locale stuff in env vars we could dig into. definitely no countrycode is easier.

jdouglas-nz commented 4 years ago

Closing this due to inactivity. If you still have this issue or want further help, please open another ticket for me :)