search

SiarheiFedartsou / fastlane-plugin-versioning

Extends fastlane versioning actions. Allows to set/get versions without using agvtool and do some other small tricks.
MIT License
504 stars 60 forks source link

get_version_number_from_git_branch error #3

Closed jsonfellin closed 7 years ago

jsonfellin commented 7 years ago

I'm getting this error message "wrong number of arguments (given 0, expected 1)" whether I add in the pattern argument or not. Any ideas @SiarheiFedartsou?

SiarheiFedartsou commented 7 years ago

Hi @jsonfellin! Just fixed your issue and released version 0.2.5. Thanks and be free to open new issues if you will find some bugs.

jsonfellin commented 7 years ago

How do I update to 0.2.5? I tried this command: fastlane install_plugins

drosenstark commented 7 years ago

Instructions say to use fastlane update_plugins... this won't actually work, however.

+------------+--------------+----------------+
|          Plugin updates available          |
+------------+--------------+----------------+
| Plugin     | Your Version | Latest Version |
+------------+--------------+----------------+
| versioning | 0.2.4        | 0.2.5          |
+------------+--------------+----------------+
[11:53:56]: To update all plugins, just run
[11:53:56]: $ fastlane update_plugins
SiarheiFedartsou commented 7 years ago

@drosenstark Why it doesn't work? Could you share fastlane update_plugins output?

drosenstark commented 7 years ago

Sure, this is the output

[13:09:51]: Seems like launching fastlane takes a while
[13:09:51]: fastlane detected a Gemfile in this directory
[13:09:51]: however it seems like you don't use `bundle exec`
[13:09:51]: to launch fastlane faster, please use
[13:09:51]: 
[13:09:51]: $ bundle exec fastlane update_plugins
[13:09:51]: For more information, check out https://guides.cocoapods.org/using/a-gemfile.html
+----------------------------+---------+------------------------------------+
|                               Used plugins                                |
+----------------------------+---------+------------------------------------+
| Plugin                     | Version | Action                             |
+----------------------------+---------+------------------------------------+
| fastlane-plugin-versioning | 0.2.4   | get_app_store_version_number       |
|                            |         | get_build_number_from_plist        |
|                            |         | get_info_plist_path                |
|                            |         | get_version_number_from_git_branch |
|                            |         | get_version_number_from_plist      |
|                            |         | increment_build_number_in_plist    |
|                            |         | increment_version_number_in_plist  |
+----------------------------+---------+------------------------------------+

Updating plugin dependencies...
/Users/dan/dans-data/projects/midiDesigner/iPadMidiDesigner/vendor/bundle/ruby/2.0.0/gems/xcode-install-2.0.9/bin/🎉 maybe `gem pristine xcode-install` will fix it?
Successfully updated plugins

But then on next run I get

[!] Run `fastlane` the next time you need to build, test or release your app 🚀
+------------+--------------+----------------+
|          Plugin updates available          |
+------------+--------------+----------------+
| Plugin     | Your Version | Latest Version |
+------------+--------------+----------------+
| versioning | 0.2.4        | 0.2.5          |
+------------+--------------+----------------+
[13:10:56]: To update all plugins, just run
[13:10:56]: $ fastlane update_plugins
drosenstark commented 7 years ago

This worked, however:

sudo gem update fastlane-plugin-versioning

Thanks!

SiarheiFedartsou commented 7 years ago

Hm, maybe there is some issue in fastlane's update_plugins command... I'll try to investigate it later. Thanks for workaround @drosenstark!

drosenstark commented 7 years ago

Glad to help. Let me know if you need any config files from me. Thanks.