search

SiarheiFedartsou / fastlane-plugin-versioning

Extends fastlane versioning actions. Allows to set/get versions without using agvtool and do some other small tricks.
MIT License
509 stars 61 forks source link

Can't get correct scheme #5

Closed yonaskolb closed 7 years ago

yonaskolb commented 7 years ago

I get an error saying `Couldn't find specified scheme'. I believe this is an issue when your specified scheme and target have different names. The get_info_plist_path seems to want a scheme but the option for it is named target, as you can see on this line https://github.com/SiarheiFedartsou/fastlane-plugin-versioning/blob/master/lib/fastlane/plugin/versioning/actions/get_info_plist_path.rb#L16 The target parameter should be renamed to scheme

yonaskolb commented 7 years ago

This used to work correctly in 0.2.5

SiarheiFedartsou commented 7 years ago

Hm, yes, I will consider renaming "target" to "scheme" or just adding alias.

Also since 0.2.6 to work correctly your scheme must be "shared"(sorry for this restriction, it was done to fix #4). To make your scheme shared go to "Manage schemes" in Xcode and tick "Shared" checkbox near your scheme name.

Did adding scheme name instead of target help to solve your problem?

yonaskolb commented 7 years ago

Passing in a scheme to the target parameter would have worked, but I have instead reverted to 0.2.5 as this is a breaking change, and I'd rather not have to pass in a scheme. In my opinion, it should work passing in a scheme OR a target plus a build_configuration_name if the value is configuration dependant

dyang commented 7 years ago

Same issue here. I'm bypassing this issue by passing in scheme as target. Hope to see a fix. :)

ilyawiz commented 7 years ago

yea - same here. passing scheme name for target name, otherwise the script asks me to select a scheme every time

drosenstark commented 7 years ago

@SiarheiFedartsou I'm not following. Is there a bug where you confuse target and scheme or not? Mine are always named the same so I wouldn't notice. Thanks for this plugin!

yonaskolb commented 7 years ago

Any updates on this?

SiarheiFedartsou commented 7 years ago

Hi all! Finally found a couple of hours to fix this issue :) Just released version 0.2.7. In 0.2.7 you can pass either target or scheme to actions. If you pass target it will work like 0.2.5, if you pass scheme it will work like 0.2.6. Feel free to re-open this issue in case of similar problems.