search

SiarheiFedartsou / fastlane-plugin-versioning

Extends fastlane versioning actions. Allows to set/get versions without using agvtool and do some other small tricks.
MIT License
504 stars 60 forks source link

correct parameter #51

Closed shuima101 closed 4 years ago

shuima101 commented 4 years ago

wrong parameter when set/get version number from xcodeproj

jdouglas-nz commented 4 years ago

Hi @shuima101 - thanks for the PR ! I think there might be some overlap between this PR and the one that @prathmeshranaut created. The main thing that's holding that up is either adding unit tests to cover this - or modifying existing ones so that the actually make sense. have you perchance ran the unit tests on your changes?

jdouglas-nz commented 4 years ago

I will work on this tonight (in 5-8hours time). Prepping for Covid-19 has chewed up a lot of time as of late.

jdouglas-nz commented 4 years ago

thank you for the PR @shuima101 ! - However, I've added the required unit tests to @prathmeshranaut 's PR and have merged his changes.