SiarheiFedartsou / fastlane-plugin-versioning

Extends fastlane versioning actions. Allows to set/get versions without using agvtool and do some other small tricks.
MIT License
509 stars 61 forks source link

get_version_number_from_xcodeproj with target and build_configuration_name cases an error #55

Closed jefferythomas closed 4 years ago

jefferythomas commented 4 years ago
get_version_number_from_xcodeproj target: target, build_configuration_name: "Release"

results in

INFO [2020-08-17 15:47:34.10]: -----------------------------------------------
INFO [2020-08-17 15:47:34.10]: --- Step: get_version_number_from_xcodeproj ---
INFO [2020-08-17 15:47:34.10]: -----------------------------------------------
ERROR [2020-08-17 15:47:34.55]: Unknown method 'plist'

get_version_number_from_xcodeproj.rb:44

UI.user_error! "Cannot resolve $(MARKETING_VERSION) build setting for #{build_configuration_name}." if plist.nil?

should be

UI.user_error! "Cannot resolve $(MARKETING_VERSION) build setting for #{build_configuration_name}." if version_number.nil?
jefferythomas commented 4 years ago

This is duplicate of (https://github.com/SiarheiFedartsou/fastlane-plugin-versioning/issues/52)

jdouglas-nz commented 4 years ago

@jefferythomas thanks for the hint! I'll get on the fix now