Sibabalo97 / Kota-app

0 stars 0 forks source link

Running the application #1

Open jaqhorn opened 10 months ago

jaqhorn commented 10 months ago

Hello, Gotbot Developer here,

I've reviewed your application, and here are my observations:

  1. The README lacks detailed instructions for running the app. It seems that the application consists of a Golang server and a React front-end. I assume the server is started with go build followed by running the executable, and the frontend is initiated with npm start.

  2. There are two missing packages in your package.json. It appears that they might be installed globally or without the -D or -S flag in your development environment. The missing packages are:

    • axios
    • react-router-dom
  3. Your project has only two commits, which limits the ability to understand your thought process and problem-solving approach.

Suggestions:

Great effort on tackling this test! As a frontend developer, you've demonstrated a solid understanding of the React framework. It's encouraging to see your willingness to delve into the backend environment. This test is indeed challenging and will test your abilities, but your performance so far is commendable. Keep up the good work!

Best regards. Your friendly neighbourhood Gotbot developer

Sibabalo97 commented 10 months ago

Hello, Gotbot Developer @jaqhorn

thank you very much for your feedback & observations in my application , it helps a lot so I can know where I lack as a developer

I agree the test was tricky as I was using work PC so it did not allow me to install some packages having said that I will improve on your observations

would you like me to make those observations or changes now and push them or they were for future reference

Best Regards Sibabalo

Sibabalo97 commented 10 months ago

@jaqhorn please review when you get a moment the app can run now I have made changes as suggested

thank you

jaqhorn commented 10 months ago

@Sibabalo97 Thanks for promptly acting on the suggestions – it really shows your ability to adapt and respond positively. Could you review your submission and let me know if it's complete and you're fully satisfied with it? Your response will demonstrate your attention to detail and understanding of the project's expectations.

Sibabalo97 commented 10 months ago

Hi @jaqhorn I have reviewed my submission , I cloned the Repo multiple times to to check that it can run successfully without having to install packages or dependencies to it , I ran docker image and ran it on port 3000 successfully updated the structure and Using git more when pushing my commits to the Repo , I would say I'm satisfied with my submission as I have tackled your observations it is now complete I have also Updated ReadMe file steps on how to run the app successfully

Sibabalo97 commented 10 months ago

hi @jaqhorn are you still reviewing my submission ?

thanks