Sibusten / derpibooru-downloader

A downloader for imageboards running Philomena, such as Derpibooru.
MIT License
62 stars 6 forks source link

Potential memory leak causing crash after extended use #2

Open Sibusten opened 7 years ago

Sibusten commented 7 years ago

Program has crashed on me several times after extended use (anywhere from one day to several) and running many downloads over that time. Unsure what is causing it, could be a memory leak or some other unhandled exception. Process does seem to grow in memory after each run.

Will have to look more into it sometime.

fionnafire commented 7 years ago

When I start the EXE I get this error: "This application failed to start because it could not find or load the Qt platform plugin "windows""

derpidown1 derpidown2

I did some googling but even after adding "qwindows.dll" in a subfolder labeled "platforms" it still won't get past the above error.

derpidown3

Sibusten commented 7 years ago

Thank you for bringing this to my attention, I seem to have forgotten to include that in any of the releases I did. I've added it to the latest release.

Not all dlls are the same, even if they have the same name, so please try it with the one I provided and let me know if it works.

https://github.com/Sibusten/derpibooru-downloader/releases/tag/v1.3.1

fionnafire commented 7 years ago

yes! it works perfectly now! I've been waiting for a program like this to be made for like two years! thank you!!

Sibusten commented 7 years ago

You're welcome, I am glad it is working properly now.

If you have any further comments or questions, feel free to open up an issue for them. Thank you again.

EpicLPer commented 7 years ago

I think you should close this issue so others won't think there still is one ;)

Sibusten commented 7 years ago

There is still an issue, with the original crash related to memory leaking. I don't keep the program open long enough to know if it's still there, but I never fixed it. The rest of the posts are about an unrelated crash that should have been it's own issue, but I just answered it here instead of telling them to move it.

I changed the title to reflect this.

fionnafire commented 7 years ago

Sorry. I didn't really know how GitHub worked.

Sibusten commented 7 years ago

It's alright, no big deal. For future reference, there is a green "New Issue" button in the top right that you can use to start a new issue.